On Wed, 2014-04-23 at 18:09 +0400, Sergei Shtylyov wrote: > On 23-04-2014 17:53, Ivan T. Ivanov wrote: > > >>>>>> --- a/include/linux/usb/msm_hsusb_hw.h > >>>>>> +++ b/include/linux/usb/msm_hsusb_hw.h > >>>>>> @@ -31,8 +31,9 @@ > >>>>>> #define USB_USBINTR (MSM_USB_BASE + 0x0148) > >>>>>> > >>>>>> #define PORTSC_PHCD (1 << 23) /* phy suspend mode */ > >>>>>> -#define PORTSC_PTS_MASK (3 << 30) > >>>>>> -#define PORTSC_PTS_ULPI (3 << 30) > >>>>>> +#define PORTSC_PTS_MASK (3 << 30) > >>>>>> +#define PORTSC_PTS_ULPI (2 << 30) > >>>>>> +#define PORTSC_PTS_SERIAL (3 << 30) > > >>>>> Please use tabs, not spaces here. > > >>>> Thanks, will fix and resend. > > >>> I answered too quickly. File contain tabs and spaces for > >>> indentation of definitions. > > >> You mean tabs and spaces on one line? Or sometimes tabs, sometimes spaces? > > > In this particular hunk, original code uses spaces. > > That I saw. 8-) > I was asking about this file in general. Legacy :-) Could this be future cleanup? Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html