Hi, On Tue, 2014-04-22 at 17:09 +0400, Sergei Shtylyov wrote: > Hello. > > On 22-04-2014 13:20, Ivan T. Ivanov wrote: > > > From: Tim Bird <tbird20d@xxxxxxxxx> > > > Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB > > controller. This is a standard chipidea PORTSC definition, where > > a PHY_TYPE of 10b (<<30) is ULPI and 11b (<<30) is SERIAL. > > Fix the definitions and use them correctly in the driver code. > > > Signed-off-by: Tim Bird <tim.bird@xxxxxxxxxxxxxx> > > --- > > drivers/usb/phy/phy-msm-usb.c | 8 +++++--- > > include/linux/usb/msm_hsusb_hw.h | 5 +++-- > > 2 files changed, 8 insertions(+), 5 deletions(-) > > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c > > index dababf9..e83d13a 100644 > > --- a/drivers/usb/phy/phy-msm-usb.c > > +++ b/drivers/usb/phy/phy-msm-usb.c > > @@ -287,8 +287,9 @@ static int msm_link_reset(struct msm_otg *motg) > > if (motg->phy_number) > > writel(readl(USB_PHY_CTRL2) | BIT(16), USB_PHY_CTRL2); > > > > + /* put transciever in serial mode as part of reset */ > > s/transciever/transceiver/ > > [...] > > > diff --git a/include/linux/usb/msm_hsusb_hw.h b/include/linux/usb/msm_hsusb_hw.h > > index 575c743..98d3dd8 100644 > > --- a/include/linux/usb/msm_hsusb_hw.h > > +++ b/include/linux/usb/msm_hsusb_hw.h > > @@ -31,8 +31,9 @@ > > #define USB_USBINTR (MSM_USB_BASE + 0x0148) > > > > #define PORTSC_PHCD (1 << 23) /* phy suspend mode */ > > -#define PORTSC_PTS_MASK (3 << 30) > > -#define PORTSC_PTS_ULPI (3 << 30) > > +#define PORTSC_PTS_MASK (3 << 30) > > +#define PORTSC_PTS_ULPI (2 << 30) > > +#define PORTSC_PTS_SERIAL (3 << 30) > > Please use tabs, not spaces here. Thanks, will fix and resend. Ivan > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
