RE: libusbg - is really fork required?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Matt Porter [mailto:mporter@xxxxxxxxxx]
> Sent: Wednesday, April 02, 2014 3:45 PM
> To: Krzysztof Opasiak
>
> Yes, I apologize for the situation, we can fix it now.
> 
> First, the work is great. I've caught up on everything but the last
> series and will apply it all now. I don't want you to give up on
> this or
> have the idea that I don't value your participation in this..and
> frankly, you've taken this a long way already. So, see my comment
> on the
> pull request. I'm prepared to merge all of this except the last
> series
> "libusbg: Add remove gadget/config/func/binding functionality" as
> that
> still needs some thought as far as changing the API wrt to function
> names use. Let's start there and get caught up to the present.

Sounds reasonable to me. In my opinion a good place to start the top of my today patches [1] but without remove functionality in the tree. I have everything prepared and I suggest:

1) Merge github pull request #1 [2]. This pull request contains all patches from the list except of those which contains remove gadget/func etc functionality and without today patches: Small bug fixes and rework of API. So that are the patches with which you are up to date as you write above.

2) Review and merge pull request #2 [3]. This pull request contains 5 patches which I have sent today (v2 version). There are some important bug fixes with memory management and uninitialized variable which I think should be reviewed and merged asap to keep libusbg working correctly

3) Review and consider pull request #3 [4]. This pull request contains patches with remove functionality. I'm opened for your suggestions and waiting for your remarks about them and I hope that we can go through this quickly and after some changes it will be also reasonable to merge this.

4) I think that here will be a good place to bump version of libusbg to 0.2.0 because library will be in usable and working state.

> 
> > 1) You become more active, review and merge all the patches and
> > participate in further development
> 
> I'm finally starting to do that now. ;)

Great looking forward for some remarks:)

> 
> >
> > 2) You will provide me RW access to libusbg github account what
> > determines that I will become maintainer/submaintainer of this
> project
> > and merge those patches and continue development
> 
> After we do merge the updated pull request I plan to add you as a
> co-maintainer with RW access to the github tree. We'll update the
> docs
> to reflect that.
> 
> Thanks for your persistence here.

Sounds good to me :) looking forward for merge and suitable access rights:)
I hope that our future cooperation will be much more active and beneficial for this project;)

Footnotes:

1 - http://marc.info/?l=linux-usb&m=139646061726183&w=2

2 - https://github.com/libusbg/libusbg/pull/1

3 - https://github.com/libusbg/libusbg/pull/2

4 - https://github.com/libusbg/libusbg/pull/3

--
BR's
Krzysiek


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux