Hello guys,
Currently i've done this in xhci-pci.c
#define PCI_VENDOR_ID_RENESAS 0x1912
#define PCI_DEVICE_ID_RENESAS_UPD720201 0x0014
if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
pdev->device == PCI_DEVICE_ID_RENESAS_UPD720201 &&
pdev->revision == 0x3)
xhci->quirks |= XHCI_NEC_HOST;
The warnings are gone.
Perhaps this quirk needs to apply to all Renesas controllers ? This addition
i've made obviously specifically matches the card I've got but the NEC match
in xhci-pci.c obviously isn't matching the Renesas vendor ID only NEC.
if (pdev->vendor == PCI_VENDOR_ID_NEC)
xhci->quirks |= XHCI_NEC_HOST;
Maybe this needs an && PCI_VENDOR_ID_RENESAS
Regards,
Will Trives
On Wednesday 05 February 2014 16:50:37 Sarah Sharp wrote:
> On Wed, Feb 05, 2014 at 09:44:20AM +0000, David Laight wrote:
> > From: Mark Lord
> >
> > > >> Which means that the controller is obeying the rules, and the
> > > >> software is wrong.> >
> > > ..
> > >
> > > > In this case, the bug has been worked around (not perfectly), but
> > > > we've
> > > > had no customer reports that this is an issue. There is no
> > > > user-visible
> > > > impact as far as we know. So fixing this race condition is a really
> > > > low
> > > > priority for me, and the fix would have to very minimally touch the
> > > > driver.
> >
> > I'm seeing the problem with the ASMedia controller (rev 0.96).
> > Your fix is only active for rev 1.00 controllers.
>
> Ok, then let's add a quirk for that host. Are you sure you don't need
> XHCI_TRUST_TX_LENGTH instead of XHCI_SPURIOUS_SUCCESS? Will reported
> seeing messages about needing XHCI_TRUST_TX_LENGTH.
>
> Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
