On Thu, Nov 07, 2013 at 12:55:04PM -0500, Alan Ott wrote: > On 11/06/2013 08:04 AM, Stanislaw Wadas wrote: > >In reference to the message sent by Andrzej Pietrasiewicz > >(about libusbg (formerly libgadget)) I would like to propose > >some changes to libusbg. > > > >Creating directories is now performed after successful memory > >allocation and gadget function creation. Hard coded values are > >replaced with constants. Error handling added to functions that > >operates on strings. > > > >Changes since v3: > > - changes are now in four separate files > > - fixed code indentation > > > >Changes since v2: > > - fixed code indentation > > - removed unused variable ret > > > >Changes since v1: > > - fixed typos in MAX_LENGTH throughout > > > >Stanislaw Wadas (2): > > libusbg: Moved mkdir functions, added MAX_LENGTH & MAX_PATH_LENGTH > > libusbg: added fputs()/fgets() error handling > > > > It's preferred to use present tense in commit messages: > "Move mkdir functions and add.... " > "Add puts()/gets() error handling" Yes, thank you ;) Stanislaw: can you incorporate Alan's comment please? Except for the remaining comment on 2/2 and changing to use present tense in the commit messages, I will be able to merge this series. Thanks, Matt -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
