On Fri, Jan 17, 2014 at 05:15:49PM +0100, Matthieu CASTET wrote: > Le Fri, 17 Jan 2014 16:54:07 +0100, > Michael Grzeschik <mgr@xxxxxxxxxxxxxx> a écrit : > > > Hi Peter, > > > > we recently see a lot of warnings with the chipidea udc. > > The driver is running as g_ether gadget. > > > > cat drivers/usb/chipidea/udc.c > > ... > > > > if (i != 0) { > > dev_warn(ci->dev, "ctrl traffic at endpoint %d\n", i); > > continue; > > } > > ... > > > > > > Do you know if this condition is correct anyway? It checks > > for fifonumbers different to zero. As I know fifo zero is > > ep0out. The core has the ep0in fifo on position 8, that > > should also handle ctrl traffic IMHO. > > > How many fifo have your controller (hw_ep_max) ? It's MX28. For this hw_ep_max is 16. > When you say fifo on position 8, you mean in software (in ci_hw_ep > array), but not in hardware (ENDPTCTRLx) ? Yes. In the code "i" is the index of the hwep array. AFAIK the array is organized like this; i == [0:7] out endpoints i == [8:15] in endpoints. Therefor index 0 is ep0out and index 8 is ep0in. Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html