On Mon, Jan 13, 2014 at 10:49:49AM -0500, Don Zickus wrote: > Some co-workers of mine bought Samsung laptops that had mostly usb3 ports. > Those ports did not resume correctly (the driver would timeout communicating > and fail). This led to frustration as suspend/resume is a common use for > laptops. > > Poking around, I applied the reset on resume quirk to this chipset and the > resume started working. Reloading the xhci_hcd module had been the temporary > workaround. > > Not sure if I should restrict this further or not. Probably should be sent > to stable too. Can you provide the `sudo lspci -vvv -n` for the xHCI host? I would rather restrict this quirk further, since this is the first report I've seen of an NEC host needing this quirk. I would rather limit it to a Samsung subsystem vendor ID if that's available. Sarah Sharp > Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx> > --- > drivers/usb/host/xhci-pci.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index 73f5208..2a21892 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -144,6 +144,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) > } > if (pdev->vendor == PCI_VENDOR_ID_VIA) > xhci->quirks |= XHCI_RESET_ON_RESUME; > + if (pdev->vendor == PCI_VENDOR_ID_RENESAS) > + xhci->quirks |= XHCI_RESET_ON_RESUME; > } > > /* called during probe() after chip reset completes */ > -- > 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
