Re: [PATCH v2 1/4] usb: gadget: FunctionFS: dereference ffs_dev conditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 13 2014, Andrzej Pietrasiewicz wrote:
> ffs_dev->ffs_release_dev_callback should be accessed only if ffs_dev
> is not NULL.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

> ---
>  drivers/usb/gadget/f_fs.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
> index 306a2b5..78333f0 100644
> --- a/drivers/usb/gadget/f_fs.c
> +++ b/drivers/usb/gadget/f_fs.c
> @@ -2590,11 +2590,12 @@ static void ffs_release_dev(struct ffs_data *ffs_data)
>  	ffs_dev_lock();
>  
>  	ffs_dev = ffs_data->private_data;
> -	if (ffs_dev)
> +	if (ffs_dev) {
>  		ffs_dev->mounted = false;
> -	
> -	if (ffs_dev->ffs_release_dev_callback)
> -		ffs_dev->ffs_release_dev_callback(ffs_dev);
> +
> +		if (ffs_dev->ffs_release_dev_callback)
> +			ffs_dev->ffs_release_dev_callback(ffs_dev);
> +	}
>  
>  	ffs_dev_unlock();
>  }
> -- 
> 1.7.0.4
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux