Re: [0/4] overlayfs: Adjustments for ovl_fill_super()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Jan 10, 2024 at 3:01 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> >> See also:
> >>
> >>
> >
> > I will queue cleanup patches 1-2,
> Thanks for this positive feedback.

Sorry, these patches do not apply to master branch and patch 1
is no longer correct in master branch and the new mount api changes.

> >                                   but I do not like patches 3/4 and 4/4.
> > I do not think that they make the code better to read or maintain.
> I would appreciate if the details for such change reluctance can be clarified better.

patch 3:
I much rather a single error handling label that takes care of
all the cleanups - it is harder to make mistakes and jump to
the wrong label when adding new error conditions.

patch 4:
Overlayfs uses this coding style all over the place

  err = -ENOMEM;
  ofs->creator_cred = cred = prepare_creds();
  if (!cred)
      goto out_free_ofs;

I don't see the benefit in making err = -ENOMEM conditional.
I don't see the style after your patch as clearly better than before.


[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux