On Wed, 25 Oct 2023 at 06:40, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> On Mon, Oct 16, 2023 at 12:27 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> >
> > On Sun, 15 Oct 2023 at 08:58, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> >
> > > + for (nr = 0; nr < nr_added_lower; nr++, lowerdirs++) {
> > > + if (nr < nr_merged_lower)
> > > + seq_show_option(m, "lowerdir+", *lowerdirs);
> > > + else
> > > + seq_show_option(m, "datadir+", *lowerdirs);
> >
> > Good.
> >
>
> And if we are going to show lowerdir+/datadir+ in a comma separated
> string, we might as well also support them with FSCONFIG_SET_STRING
> as long as they don't need escaping.
My patch does support SET_STRING. The difference is that string
param will be shown in mountinfo unchanged, while a path param will
be canonicalized. It's interesting, because using string params and
legacy interfaces can hide the location of the layers. OTOH they
allow for less cluttered mountinfo. So I guess this difference can
be an advantage and a disadvantage too, depending on your point of
view, but it's probably not something we want to change.
>
> I think this may even be more important than supporting path params
> just to restore the feature that was retroactively disabled in 6.5.y.
Yeah, that would be a good way to split this up.
> We can later add FSCONFIG_SET_PATH support for all those params.
>
> I can take on writing the string params patch based on your POC,
> including the fstests, which are quite simple to do in bash for string params.
Okay, thanks.
Miklos
