On Sun, 15 Oct 2023 at 08:58, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> + for (nr = 0; nr < nr_added_lower; nr++, lowerdirs++) {
> + if (nr < nr_merged_lower)
> + seq_show_option(m, "lowerdir+", *lowerdirs);
> + else
> + seq_show_option(m, "datadir+", *lowerdirs);
Good.
I did some testing and it turns out libmount still regresses on
6.6-rc6 for the escaped comma case. The reason is that libmount
doesn't understand escaping of commas, hence the '-oupper=upper\,1'
will result in two fsconfig() calls: 'upper=upper\' and '1'. Prior
to 6.5 these were nicely reconstructed into the original
'upper=upper\,1' by legacy_parse_param().
The same reconstructing could be done by ovl_parse_param() when
detecting an option ending with a backslash. But I guess we only need
to do this if there's a report of such a regression.
But this raises the question: shouldn't we turn off comma unescaping,
since it's useless?
Going further, unescaping in general for upperdir and workdir could be
turned off (lowerdir+ and datadir+ are naturally escape free), leaving
only unescaping in lowerdir?
Yes, that also has the potential to regress something out there. But
it also has the potential to clean up the interface further if no such
regression happens. And I don't think we need to hurry, the 6.7
cycle would be good for experimenting.
Thanks,
Miklos
