Re: [PATCH] ovl: fix regression in showing lowerdir mount option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 16, 2023 at 12:27 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Sun, 15 Oct 2023 at 08:58, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> > +       for (nr = 0; nr < nr_added_lower; nr++, lowerdirs++) {
> > +               if (nr < nr_merged_lower)
> > +                       seq_show_option(m, "lowerdir+", *lowerdirs);
> > +               else
> > +                       seq_show_option(m, "datadir+", *lowerdirs);
>
> Good.
>

And if we are going to show lowerdir+/datadir+ in a comma separated
string, we might as well also support them with FSCONFIG_SET_STRING
as long as they don't need escaping.

I think this may even be more important than supporting path params
just to restore the feature that was retroactively disabled in 6.5.y.
We can later add FSCONFIG_SET_PATH support for all those params.

I can take on writing the string params patch based on your POC,
including the fstests, which are quite simple to do in bash for string params.

Thanks,
Amir.




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux