On Sat, 8 Apr 2023 at 18:43, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>
> Now that we have the entire lower stack in ovl_inode, we do not
> need to hold another reference to the lowerdata inode.
>
> Instead, use the vacant ovl_inode space as a place holder for lowerdata
> redirect path from the metacopy to lowerdata, which is going to be used
> later on for lazy lowerdata lookup.
Seems like this patch is combining two independent changes into one.
Could this be spit into
- remove lowerdata
- add lowerdata_redirect
?
> + /* Store lowerdata redirect for lazy lookup */
> + if (ctr > 1 && !d.is_dir && !stack[ctr - 1].dentry) {
So lazy lookup will be signaled with a NULL dentry? This should be
spelled out in the patch header.
Thanks,
Miklos
