On Wed, Apr 26, 2023 at 3:39 PM Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> On Sat, 8 Apr 2023 at 18:43, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> >
> > Now that we have the entire lower stack in ovl_inode, we do not
> > need to hold another reference to the lowerdata inode.
> >
> > Instead, use the vacant ovl_inode space as a place holder for lowerdata
> > redirect path from the metacopy to lowerdata, which is going to be used
> > later on for lazy lowerdata lookup.
>
> Seems like this patch is combining two independent changes into one.
> Could this be spit into
>
> - remove lowerdata
> - add lowerdata_redirect
>
> ?
Yeh, ok.
I posted it like that for review because I thought it would be
easier to review.
But really remove lowerdata belongs to this prep series
and add lowerdata_redirect belongs to the next one so
I wont mix them
>
>
>
> > + /* Store lowerdata redirect for lazy lookup */
> > + if (ctr > 1 && !d.is_dir && !stack[ctr - 1].dentry) {
>
> So lazy lookup will be signaled with a NULL dentry? This should be
> spelled out in the patch header.
>
This also doesnt belong to this series.
Thanks,
Amir.
