On Thu, Apr 9, 2020 at 4:25 PM zhangyi (F) <yi.zhang@xxxxxxxxxx> wrote: > > Hi, Amir > > On 2020/4/9 19:21, Amir Goldstein wrote: > [...] > > > > Thanks for taking the time to report all those failures. > > You must be one of few developers to actually use fsck.overlayfs... > > > > You need this fix for fsck.overlayfs: > > https://github.com/hisilicon/overlayfs-progs/pull/1 > > > > Sorry, I forgot I was carrying this patch on my setup. > > > > Zhangyi, > > > > Any chance of merging my fix? > > > > Thanks for the patch, I think we'd better to remove the FS_LAYER_XATTR flag I have no idea why I set this flag. It was a long time ago... It really doesn't make sense and does not match what commit message says. > for a nested overlayfs layer, so we could skip checking OVL_XATTR_PREFIX > xattrs when scanning the layer. Something like this, > > + /* A nested overlayfs does not support OVL_XATTR_PREFIX xattr */ > + if (statfs.f_type == OVERLAYFS_SUPER_MAGIC) > + return 0; > > I will modify this and merge your patch. > Thanks, Amir.
