Re: [PATCH v2] ovl: sharing inode with different whiteout files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 8, 2020 at 5:11 AM Chengguang Xu <cgxu519@xxxxxxxxxxxx> wrote:
>
>  ---- 在 星期三, 2020-04-08 01:12:59 Amir Goldstein <amir73il@xxxxxxxxx> 撰写 ----
>  > >  > did nfs_export tests fail with my recent branch (c1fe7dcb3db8)?
>  > >  > because I had a bug that caused nfs_export tests to fail.
>  > >  >
>  > >  >
>  > >  > ...
>  > >  >
>  > >
>  > > Actually, it is "not run" not fail. I'm not very familiar how to run with nfs_export,
>  > > is it needing some special options?
>  > >
>  > > test log below:
>  > >
>  > > overlay/068     [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/069     [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/070     [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/071     [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > >
>  > > overlay/050 4s ... [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/051 3s ... [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/052 1s ... [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/053 2s ... [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/054 1s ... [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > > overlay/055 1s ... [not run] overlay feature 'nfs_export' cannot be enabled on /mnt/scratch
>  > >
>  > >
>  >
>  > It depends which filesystem you have as lower/upper or
>  > which mount options you used for the xfstests setup.
>  > dmesg should give you a clue for why nfs_export could not be
>  > enabled on overlayfs.
>  >
>
> nfs_export and metacopy are incompatible.
> I tested "workdir" branch(latest commit is commit c1fe7dcb3db8ed8e84986eec07e0b302ee3b83de)
> in your git tree and found three more fails.

I figured that might me it.
Please share more configuration details of your setup.
How is metacopy enabled on your system?
How are you running xfstests? Can you share the config file?
Details of the underlying filesystems.

>
> ----------------------------------
>
> overlay/029 1s ... - output mismatch (see /home/cgxu/git/xfstests-dev/results//overlay/029.out.bad)
>     --- tests/overlay/029.out   2019-11-07 09:05:18.876796433 +0800
>     +++ /home/cgxu/git/xfstests-dev/results//overlay/029.out.bad        2020-04-08 09:55:07.462699895 +0800
>     @@ -1,5 +1,9 @@
>      QA output created by 029
>      foo
>     -bar
>     -foo
>     -bar
>     +mount: /tmp/8751/mnt: mount(2) system call failed: Stale file handle.

The reason for this error should be in dmesg.

>     +cat: /tmp/8751/mnt/bar: No such file or directory
>     ...
>     (Run 'diff -u /home/cgxu/git/xfstests-dev/tests/overlay/029.out /home/cgxu/git/xfstests-dev/results//overlay/029.out.bad'  to see the entire diff)
>
> overlay/070     [failed, exit status 1]- output mismatch (see /home/cgxu/git/xfstests-dev/results//overlay/070.out.bad)
>     --- tests/overlay/070.out   2020-04-07 09:16:59.102568756 +0800
>     +++ /home/cgxu/git/xfstests-dev/results//overlay/070.out.bad        2020-04-08 09:55:38.580311600 +0800
>     @@ -1,2 +1,26 @@
>      QA output created by 070
>     -Silence is golden
>     +umount: /mnt/scratch: target is busy.

This failure has do to with somthing that happened before the test.
Its trails should be in dmesg.

>     +rm: cannot remove '/mnt/scratch/ovl-mnt': Device or resource busy
>     +losetup: /mnt/scratch/ovl-lower/img: failed to set up loop device: No such file or directory
>     +cp: target '/mnt/scratch/ovl-lower/lowertestdir/blkdev' is not a directory
>     +cp: target '/mnt/scratch/ovl-upper/uppertestdir/blkdev' is not a directory
>     ...
>     (Run 'diff -u /home/cgxu/git/xfstests-dev/tests/overlay/070.out /home/cgxu/git/xfstests-dev/results//overlay/070.out.bad'  to see the entire diff)
>
> overlay/071     - output mismatch (see /home/cgxu/git/xfstests-dev/results//overlay/071.out.bad)
>     --- tests/overlay/071.out   2020-04-07 09:16:59.102568756 +0800
>     +++ /home/cgxu/git/xfstests-dev/results//overlay/071.out.bad        2020-04-08 09:55:39.899295141 +0800
>     @@ -1,2 +1,6 @@
>      QA output created by 071
>     +_overlay_check_fs: overlayfs on /mnt/scratch/ovl-mnt,/ovl-upper.2,/ovl-work.2 is inconsistent
>     +(see /home/cgxu/git/xfstests-dev/results//overlay/071.full for details)
>     +_overlay_check_fs: overlayfs on /mnt/scratch/ovl-mnt,/ovl-upper.2,/ovl-work.2 is inconsistent
>     +(see /home/cgxu/git/xfstests-dev/results//overlay/071.full for details)
>      Silence is golden
>

What do the full log details say?
again, its probably a result of some previous failure.

FWIW, I ran:
kvm-xfstests -c overlay/large -g overlay/quick -m metacopy=on

And there were no errors. The nfs_exports tests did [not run]

Thanks,
Amir.




[Index of Archives]     [Linux Filesystems Devel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux