On Thu, Nov 9, 2017 at 12:07 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Tue, Nov 7, 2017 at 10:38 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> Miklos, >> >> This series is complementary to the whiteouts expose patches. >> Patch 2 restores origin xattr on lookup of merge dir (that was copied up >> before v4.12). >> Patch 3 sets a 'null' origin fh on dir if we happen to iterate an 'impure' >> dir and find a whiteout while looking for copy ups. This is expected to >> happen if merge dir was copied up before v4.12, but files inside it were >> copied up after v4.12. > > Applied 1/3. > > Does the other two patches have any real usecase? AFAICS this is not > fixing a backward compatibility issue, so I'm sceptical of the value. No real usecase for me. I don't mind if they stay out, but I'll explain why I posted them. Patch 2/3 is just pieces from 'verify_dir' patches, so I figured it may be useful on its own for this purpose. Patch 3/3 is just something I saw as 'low hanging' - if we lookup impure files anyway and detect a whiteouts - there is a proper response, so why not use it? All copy ups since v4.12 mark the parent dir "impure", but not "origin" what's the logic in taking care of impurity of parent on copy up and not taking care of parent whiteouts? So I see these patches as "consistent behavior" patches, rather than any MUST. Could be handled by fsck.overlayfs, which should also handle migration of origin file handles to new location anyway. Cheers, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
