On 2017/11/9 18:07, Miklos Szeredi Wrote: > On Tue, Nov 7, 2017 at 10:38 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> Miklos, >> >> This series is complementary to the whiteouts expose patches. >> Patch 2 restores origin xattr on lookup of merge dir (that was copied up >> before v4.12). >> Patch 3 sets a 'null' origin fh on dir if we happen to iterate an 'impure' >> dir and find a whiteout while looking for copy ups. This is expected to >> happen if merge dir was copied up before v4.12, but files inside it were >> copied up after v4.12. > > Applied 1/3. > > Does the other two patches have any real usecase? AFAICS this is not > fixing a backward compatibility issue, so I'm sceptical of the value. > > Even if there was a real usecase, we could introduce an "fsck.overlay" > utility that would fix up overlays to be able to take advantage of new > features. Hi Miklos, Now, I am working on the "fsck.overlay" in my spare time, and the following functions have already been done: 1) Check and (auto)fix redundant whiteouts, 2) Check and (auto)fix invalid redirect/opaque xattr. But it is still a very crude version now, maybe I can send out for some suggestions next week. :) Thanks, Yi. > Thanks, > Miklos > > -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
