On Thu, Nov 9, 2017 at 11:33 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> On Wed, Nov 8, 2017 at 5:50 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>> On Wed, Nov 8, 2017 at 3:40 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>>> On Wed, Nov 8, 2017 at 2:01 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>>>> On Wed, Nov 8, 2017 at 12:53 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>>>>> On Tue, Nov 7, 2017 at 5:58 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
>>>>>> Miklos,
>>>>>>
>>>>>> This version provides a solution for some interesting non-samefs cases:
>>>>>> - All the ext* family
>>>>>> - Many other fs with default encode_fh
>>>>>> - xfs that is not huge with overlay 'xino' mount option
>>>>>> - tmpfs that is not on a machine with jurassic uptime with 'xino'
>>>>>>
>>>>>> I tested this with Chandan's upstream overlay/041 xfstest for
>>>>>> consistent d_ino in non-samefs setup. Results are:
>>>>>> - Test passes for ext4
>>>>>> - Test fails for xfs
>>>>>> - Test fails for xfs with OVERLAY_MOUNT_OPTIONS=-oxino,
>>>>>> but this is because of a test bug
>>>>>> - With the test bug fix available at [2] test passes
>>>>>> with xfs and OVERLAY_MOUNT_OPTIONS=-oxino
>>>>>>
>>>>>> All the exportfs tests also pass with these changes and
>>>>>> either ext4 or xfs with OVERLAY_MOUNT_OPTIONS=-oxino.
>>>>>>
>>>>>> Changes since v7:
>>>>>> - Drop patches for building impure cache for non-samefs subdirs
>>>>>> - Dropped patch "update cache version of impure parent on rename"
>>>>>> because it is not relevant to this series
>>>>>> - Remap lower inode numbers for 32bit inode file systems
>>>>>> - Add mount option 'xino' for opting-in to use high inode bits
>>>>>
>>>>> I the meantime I went and committed v7 (with the noted changes) and
>>>>> based my cleanup for ovl_fill_super() on top of that. So that's now
>>>>
>>>> Nice cleanup!
>>>> I don't like setting of s_d_op inside ovl_get_lowerstack().
>>>> IMO should add ufs->remote boolean because it is interesting anyway
>>>> and set s_d_op in ovl_fill_super() itself.
>>>>
>>>
>>> Mikos,
>>>
>>> ovl_fill_super() cleanup caused 3 regressions with xfstest
>>> check -overlay -g overlay/quick
>>> overlay/011 overlay/035 - mount failures instead of r/o mount
>>
>> Fixed by "fix free of ERR_PTR oe"
>>
>>> overlay/022 - dentries in use after mount failure:
>>>
>>> BUG: Dentry ffff880079fee2f8{i=42ff,n=upper} still in use (-1)
>>> [unmount of overlay overlay]
>>> BUG: Dentry ffff880079fe0338{i=2008d81,n=upper} still in use (1)
>>> [unmount of xfs vdf]
>>> BUG: Dentry ffff880079fda700{i=3000100,n=ovl-lower} still in use (1)
>>> [unmount of xfs vdf]
>>>
>>
>> Fixed by "fix double path_put() on error"
>>
>>> Another regression caused by tweaking OVL_WHITEOUTS patch:
>>> overlay/038 - A fix to the readdir regression is pushed to:
>>> https://github.com/amir73il/linux/commits/ovl-fixes
>>
>> Pushed those 2 fixes and 2 more review bug fixes to ovl-fixes branch.
>
> Thanks for testing and looking at the issues. I've now set up
> xfstests as well in my test environment...
>
You may want to try out Ted's kvm-xfstests if you haven't already.
I've set it up to also run unionmount testsuite tests from within xfstests:
https://github.com/amir73il/xfstests-bld/commits/overlayfs-devel
> Force pushed branch with fixes to overlayfs-next.
>
Looks good.
Will test.
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
