On Wed, Nov 8, 2017 at 12:53 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Tue, Nov 7, 2017 at 5:58 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> Miklos, >> >> This version provides a solution for some interesting non-samefs cases: >> - All the ext* family >> - Many other fs with default encode_fh >> - xfs that is not huge with overlay 'xino' mount option >> - tmpfs that is not on a machine with jurassic uptime with 'xino' >> >> I tested this with Chandan's upstream overlay/041 xfstest for >> consistent d_ino in non-samefs setup. Results are: >> - Test passes for ext4 >> - Test fails for xfs >> - Test fails for xfs with OVERLAY_MOUNT_OPTIONS=-oxino, >> but this is because of a test bug >> - With the test bug fix available at [2] test passes >> with xfs and OVERLAY_MOUNT_OPTIONS=-oxino >> >> All the exportfs tests also pass with these changes and >> either ext4 or xfs with OVERLAY_MOUNT_OPTIONS=-oxino. >> >> Changes since v7: >> - Drop patches for building impure cache for non-samefs subdirs >> - Dropped patch "update cache version of impure parent on rename" >> because it is not relevant to this series >> - Remap lower inode numbers for 32bit inode file systems >> - Add mount option 'xino' for opting-in to use high inode bits > > I the meantime I went and committed v7 (with the noted changes) and > based my cleanup for ovl_fill_super() on top of that. So that's now Nice cleanup! I don't like setting of s_d_op inside ovl_get_lowerstack(). IMO should add ufs->remote boolean because it is interesting anyway and set s_d_op in ovl_fill_super() itself. > pushed out to overlayfs-next, hopefully not invalidating too much of > your work. Not a problem. most of the work on v8 was on the last patches. I'll send 2 cleanup patches that make get_attr() code a bit cleaner to my taste. > > The -oxino patches are interesting, but maybe we should leave them > brewing for another cycle. Do you agree? > Sure. your call. > I'll try and look at the other series posted by you and Vivek to see > what else would fit in to 4.15. OK. I need to address a small comment by Zhangyi on restoring origin fh. Will push a fix today. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
