On Mon, Oct 30, 2017 at 02:10:52PM +0200, Amir Goldstein wrote: > On Mon, Oct 30, 2017 at 2:06 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > kernel v4.13 introduced the index=on feature for not breaking hardlinks > > on copy-up. With the index feature enabled a regression was introduced - > > lower files that are hardlined while overlay is offline can result in > > lookup error after overlay in mounted. > > > > The regression was fixed by upstream commit > > 6eaf011144af ovl: fix EIO from lookup of non-indexed upper > > that was merged to v4.14-rc7. > > > > This test verifies that behavior is sane after creating lower hardlinks > > for copied up files while overlayfs is offline. > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > --- > > > > Eryu, > > > > This is a regression test for a fix that was just merged to v4.14-rc7. > > > > The test requires and enables index=on, so it would fail on kernels > > prior to v4.14-rc7 regardless if they are complied with > > CONFIG_OVERLAY_FS_INDEX=y or not. > > > > Amir. > > > > tests/overlay/042 | 137 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/overlay/042.out | 2 + > > tests/overlay/group | 1 + > > 3 files changed, 140 insertions(+) > > create mode 100755 tests/overlay/042 > > create mode 100644 tests/overlay/042.out > > > > diff --git a/tests/overlay/042 b/tests/overlay/042 > > new file mode 100755 > > index 0000000..29858d6 > > --- /dev/null > > +++ b/tests/overlay/042 > > @@ -0,0 +1,137 @@ > > +#! /bin/bash > > +# FS QA Test 042 > > +# > > +# Test creating lower hardlinks for copied up files. > > +# > > +# kernel v4.13 introduced the index=on feature for not breaking > > +# hardlinks on copy-up. With the index feature enabled a regression was > > +# introduced - lower files that are hardlined while overlay is offline > > +# can result in lookup error after overlay in mounted. > > +# The regression was fixed by upstream commit > > Some indentation fixes I forgot to commit: > > +# kernel v4.13 introduced the index=on feature for not breaking hardlinks > +# on copy-up. With the index feature enabled a regression was introduced - > +# lower files that are hardlined while overlay is offline can result in > +# lookup error after overlay in mounted. I've fixed it up on commit, thanks! Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-unionfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
