Re: [PATCH 36/48] perf annotate-data: Introduce struct data_loc_info

[Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx>]

> On 05-Dec-2023, at 5:40 AM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> 
> Hello,
> 
> On Sun, Dec 3, 2023 at 8:22 AM Athira Rajeev
> <atrajeev@xxxxxxxxxxxxxxxxxx> wrote:
>> Hi Namhyung,
>> 
>> I have a thought there. For the type and typeoff sort keys to work, we depend on Dwarf support in perf, right ?
>> If the perf is built without dwarf support ( either due to older elfutils or missing libdw.h ) , find_data_type will return NULL and we will get “unknown” for Data Type and Data Type Offset in the result.
> 
> Yes, right.
> 
>> 
>> Can we add a pr_debug line in find_data_type (which is in else part for HAVE_DWARF_SUPPORT) so that user can understand if “unknown” is due to missing devel during the build ? Or may be restrict -s type,typeoff if dwarf support is missing ?
> 
> I think it's better to add a warning if DWARF is not supported.
> Thanks for your review!

Sure, having a warning if DWARF is not supported will help

Thanks
Athira
> 
> Namhyung