Re: [PATCH 36/48] perf annotate-data: Introduce struct data_loc_info
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 36/48] perf annotate-data: Introduce struct data_loc_info
- From: Namhyung Kim <namhyung@xxxxxxxxxx>
- Date: Mon, 4 Dec 2023 16:10:24 -0800
- Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Ian Rogers <irogers@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-perf-users <linux-perf-users@xxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Stephane Eranian <eranian@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, linux-toolchains@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx
- In-reply-to: <852644CC-CF12-475A-A7D2-84EFDCE9D248@linux.vnet.ibm.com>
- References: <20231012035111.676789-1-namhyung@kernel.org> <20231012035111.676789-37-namhyung@kernel.org> <852644CC-CF12-475A-A7D2-84EFDCE9D248@linux.vnet.ibm.com>
Hello,
On Sun, Dec 3, 2023 at 8:22 AM Athira Rajeev
<atrajeev@xxxxxxxxxxxxxxxxxx> wrote:
> Hi Namhyung,
>
> I have a thought there. For the type and typeoff sort keys to work, we depend on Dwarf support in perf, right ?
> If the perf is built without dwarf support ( either due to older elfutils or missing libdw.h ) , find_data_type will return NULL and we will get “unknown” for Data Type and Data Type Offset in the result.
Yes, right.
>
> Can we add a pr_debug line in find_data_type (which is in else part for HAVE_DWARF_SUPPORT) so that user can understand if “unknown” is due to missing devel during the build ? Or may be restrict -s type,typeoff if dwarf support is missing ?
I think it's better to add a warning if DWARF is not supported.
Thanks for your review!
Namhyung
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]
