Re: [RFC V2 12/21] rv/reactor: Add the printk reactor
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC V2 12/21] rv/reactor: Add the printk reactor
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Wed, 16 Feb 2022 09:58:50 +0100
- Cc: Jonathan Corbet <corbet@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Marco Elver <elver@xxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, Gabriele Paoloni <gpaoloni@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx
- In-reply-to: <874k50hqmj.fsf@jogness.linutronix.de>
- References: <cover.1644830251.git.bristot@kernel.org> <fad2d358d57dfffc084d482684ecc1d13b62b262.1644830251.git.bristot@kernel.org> <10cf6003-6d2b-056b-11bb-3ae9c342a369@linuxfoundation.org> <c1657d1c-0d2b-4aa3-c1ed-2ae6fdfcda86@kernel.org> <87v8xg30qc.fsf@jogness.linutronix.de> <45179cdb-2391-207a-2f7b-2dea828d1606@kernel.org> <87r1842r1m.fsf@jogness.linutronix.de> <65172f14-bad6-37b1-d243-e91ca472d22e@kernel.org> <874k50hqmj.fsf@jogness.linutronix.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0
On 2/15/22 20:33, John Ogness wrote:
>> I saw deadlocks in the past, and while testing the WIP monitor some
>> time ago, it seems it depends on the console type. If such restriction
>> does not exist anymore, I can remove that comment, it would be even
>> better!
> If you say it depended on the console type, then it was probably the
> framebuffer console that was at fault. The fbcon is a landmine for
> deadlocks, which is why PREEMPT_RT avoids fbcon printing from
> non-preemptible context. For mainline, the series is currently in
> review.
>
> Perhaps avoiding fbcon would be good enough for you to avoid deadlocks
> with this reactor using printk().
So, I will keep printk(), add a depends on *!* fbcon, and remove the comment.
What do you think?
-- Daniel
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]