Re: [RFC V2 12/21] rv/reactor: Add the printk reactor
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC V2 12/21] rv/reactor: Add the printk reactor
- From: John Ogness <john.ogness@xxxxxxxxxxxxx>
- Date: Tue, 15 Feb 2022 14:39:09 +0106
- Cc: Jonathan Corbet <corbet@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Marco Elver <elver@xxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, Gabriele Paoloni <gpaoloni@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx
- In-reply-to: <45179cdb-2391-207a-2f7b-2dea828d1606@kernel.org>
- References: <cover.1644830251.git.bristot@kernel.org> <fad2d358d57dfffc084d482684ecc1d13b62b262.1644830251.git.bristot@kernel.org> <10cf6003-6d2b-056b-11bb-3ae9c342a369@linuxfoundation.org> <c1657d1c-0d2b-4aa3-c1ed-2ae6fdfcda86@kernel.org> <87v8xg30qc.fsf@jogness.linutronix.de> <45179cdb-2391-207a-2f7b-2dea828d1606@kernel.org>
On 2022-02-15, Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
>> I suggest using printk_deferred() for this reactor for now. With
>> printk_deferred() the message and timestamp are immediately and
>> locklessly stored in the buffer, and the printing is performed in a
>> separate context. printk_deferred() is safe for all contexts.
>
> Question: Does it always postpone or only postpone when in a
> particular contexts, like, with irqs disabled?
printk_deferred() always postpones printing.
> Note: do not use this reactor with rq_lock taken, it will lock the
> system until printk can handle that.
Perhaps you could explain thi comment in your commit message? printk()
should never lock the system.
John
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]