Re: [RFC V2 12/21] rv/reactor: Add the printk reactor
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [RFC V2 12/21] rv/reactor: Add the printk reactor
- From: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
- Date: Mon, 14 Feb 2022 19:06:09 +0100
- Cc: Jonathan Corbet <corbet@xxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Marco Elver <elver@xxxxxxxxxx>, Dmitry Vyukov <dvyukov@xxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, Gabriele Paoloni <gpaoloni@xxxxxxxxxx>, Juri Lelli <juri.lelli@xxxxxxxxxx>, Clark Williams <williams@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-trace-devel@xxxxxxxxxxxxxxx
- In-reply-to: <10cf6003-6d2b-056b-11bb-3ae9c342a369@linuxfoundation.org>
- References: <cover.1644830251.git.bristot@kernel.org> <fad2d358d57dfffc084d482684ecc1d13b62b262.1644830251.git.bristot@kernel.org> <10cf6003-6d2b-056b-11bb-3ae9c342a369@linuxfoundation.org>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0
On 2/14/22 18:25, Shuah Khan wrote:
> On 2/14/22 3:45 AM, Daniel Bristot de Oliveira wrote:
>> Sample reactor that printks the reaction message.
>>
>
> Who is supposed to take action on this message and how do they
> get notified?
The same people that use printk to debug systems (who never?), on conditions
where other debugging methods might not available.
>
>> Note: do not use this reactor with rq_lock taken, it will lock the
>> system until printk can handle that.
>
> Please give more details on "lock the system" and how locking
> would impact users and system operation
It is a deadlock on the rq_lock. Hopefully the new printk implementation handles
that better.
/me looks at John Ogness
-- Daniel
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]