On Thu, Jun 18, 2020 at 6:47 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Thu, 18 Jun 2020 14:43:42 +0300 > Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote: > > > kernel/traceevent/plugins commits, should be added in > > trace-cmd/traceevent/plugins: > > "libtraceevent: Remove unneeded semicolon" > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=eebe80c982546ce1041b7dcf3c461406f1e7e88f > > "tools lib traceevent: Fix memory leakage in filter_event" > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f84ae29a6169318f9c929720c49d96323d2bbab9 > > "tools lib traceevent: Take care of return value of asprintf" > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f8ff18be1f5c6ba1c2befb043bea6e7eaf9f8987 > > The above are fine. > > > "tools lib traceevent: Added support for pkg-config" > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc03e1a8f82dff36fb329469c28cbfe7d2e6156a > > Hmm, do we need this? If the plan is to make traceevent its own > package, I don't think we need to have pkg-config for trace-cmd. > > > "tools lib traceevent: Remove hard coded install paths from > > pkg-config file" > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=53dbabfe50262eeebb56ce18789c3c885f15e6ac > > Same for this one. I don't think the libraries should be installed via trace-cmd. There is already an "install_libs" target in trace-cmd top Makefile. I think all libraries which are supposed to be used with 3th party applications should be integrated with pkg-config infrastructure. > > > > > > kernel/traceevent/plugins commits, should be added in > > trace-cmd/traceevent/plugins: > > "tools lib traceevent: update KVM plugin" > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2f465deef7ce8c722121b782dd91c284f5ae80ca > > This is good. > > Thanks Tzvetomir! > > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|