On Thu, Jun 18, 2020 at 4:58 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Thu, 18 Jun 2020 14:43:42 +0300 > Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote: > > > Hi Steven, > > These are differences in commits between both libtracevent > > implementations, in trace-cmd and in kernel. Please look at them, I'm > > going to synchronize both trees according to this list. > > > > trace-cmd/traceevent commits, should be added in kernel/traceevent: > > "trace-cmd: Introduced new traceevent API, for adding new plugins > > directories." > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=5c8ac22552af4213f81cb7839f7f262252a80855 > > "trace-cmd: Optimize pretty_print() function" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=d8c1349f44ca9ac8ef0e7f198a133603ea399a95 > > "trace-cmd: Move plugin options from trace-cmd to libtraceevent." > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=5988d3085d9ec5d7418ad49bc8c7e88c832d5ac5 > > "trace-cmd: Remove trace-cmd plugin handling routines" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=b2cf2e46a6d013d4037118274cc783570277ce32 > > "trace-cmd: Add proper KBUFFER_TYPE_TIME_STAMP handling" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=e5de44dd43523764d18dc773f82ce1b738c22e64 > > "trace-cmd: Add --debug to trace-cmd report" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=8cdbccd5ef422dc518e7246aa1c41922e834120b > > OK for the above, but they the subjects will need to change to follow > the lib/traceeevent subjects. For example: > > trace-cmd: Optimize pretty_print() function > > would become: > > tools lib traceevent: Optimize pretty_print() function > > Also, the change logs may need to be tweaked to be specific for the > library. Though they can still reference trace-cmd as a user of the > APIs. > > But keep the authors of these patches the same (From: lines). > > > > > trace-cmd/traceevent/plugins commits, should be added in > > kernel/traceevent/plugins: > > "trace-cmd report: Add -O offset for function plugin" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=1785022e12cf0079889c519ffc7157f2143326ea > > "trace-cmd: Move kernel_stack event handler to "function" plugin." > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=8ba49dad8877fbd27cd6659397a01fb9243f7953 > > "tools lib traceevent: Add builtin handler for trace_marker_raw" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=d9f4b4043a68602f869c8c73b499cd7c7b4194b9 > > "trace-cmd: Add plugin for decoding syscalls/sys_enter_futex" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=25224f44a75e2ede5c2085683c0a008980ca87e7 > > Same for the above. > > > "Change to SPDX License format" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=ff551288621dd07e9a9da433cb5b9f539c025cb6 > > This hasn't already been updated (haven't gone and looked)? Most of the files in "tools/lib/traceevent/plugins/" have no "SPDX License" header, should we update them ? > > > "trace-cmd: Add more SVM exit reasons" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=4421d9551b903d720bb8534a02c3564187eab045 > > "trace-cmd: Add plugin for tlb_flush" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=7a0ead47bdb85288c855fafae24719b1ca9b907e > > The above are fine with the same comments as the others. > > > "trace-cmd: Add hack to report out blktrace" > > https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git/commit/?id=9e0fd22b14805a3a3219a99bc5eccebf70f5484a > > Hold off on this one. > > I'll take a look at the rest later. > > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|