Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
- From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
- Date: Wed, 18 Sep 2019 16:08:37 +0300
- Cc: Joe Perches <joe@xxxxxxxxxxx>, Petr Mladek <pmladek@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, Rob Herring <robh@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>
- In-reply-to: <20190916103755.4c19eda9@gandalf.local.home>
- References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-2-sakari.ailus@linux.intel.com> <20190910071837.2e9110f8@oasis.local.home> <61a2b2ab4693535850306f396aac2a328e1d5a21.camel@perches.com> <20190910142621.0bec208d@oasis.local.home> <c458e734f5777561138b87228384808398547762.camel@perches.com> <20190910150303.5a0d3904@oasis.local.home> <c90c33b421c0fa0db5182d0f58c6ba6e86cf1622.camel@perches.com> <20190916114158.GN5781@paasikivi.fi.intel.com> <20190916103755.4c19eda9@gandalf.local.home>
- User-agent: Mutt/1.10.1 (2018-07-13)
Hi Steven,
On Mon, Sep 16, 2019 at 10:37:55AM -0400, Steven Rostedt wrote:
> > If you think that's an issue, I'll opt for another extension than %pfw,
> > which I chose originally since it's memorable --- fw for fwnode (names,
> > paths, and probably more in the future).
> >
>
> I'm fine with the switch, as long as newer tools know how to handle it.
>
> Make sure we also add a comment in the Linux kernel code that states
> that older kernels use to have 'f' and 'F' and that new tools look for
> 'fw' to denote that this isn't an older kernel. This way, people will
> hopefully not add another 'fX' pointer name.
Good point. I'll add a comment on this to make_bprint_args() in
tools/lib/traceevent/event-parse.c as well as in vsprintf.c.
--
Regards,
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]