Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
- From: Joe Perches <joe@xxxxxxxxxxx>
- Date: Tue, 10 Sep 2019 10:18:44 -0700
- Cc: Petr Mladek <pmladek@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, Rob Herring <robh@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>
- In-reply-to: <20190910071837.2e9110f8@oasis.local.home>
- References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-2-sakari.ailus@linux.intel.com> <20190910071837.2e9110f8@oasis.local.home>
- User-agent: Evolution 3.32.1-2
On Tue, 2019-09-10 at 07:18 -0400, Steven Rostedt wrote:
> On Tue, 10 Sep 2019 11:46:56 +0300
> Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> > There are no in-kernel %p[fF] users left. Convert the traceevent tool,
> > too, to align with the kernel.
[]
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
[]
> > @@ -4335,8 +4335,6 @@ static struct tep_print_arg *make_bprint_args(char *fmt, void *data, int size, s
> > switch (*ptr) {
> > case 's':
> > case 'S':
> > - case 'f':
> > - case 'F':
>
> This file is used to parse output from older kernels, so remove this hunk.
>
> It's not just for the lastest kernel. We must maintain backward
> compatibility here too. If there use to be a usage of this, then we
> must keep it until the kernels are no longer used (perhaps 7 years?)
That argues for not using "%pfw" at all for some number of years.
Perhaps the '%pfw' should be '%pnfw' for 'name' and 'fwnode'
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]