On Wed, 28 Nov 2018 09:07:29 +0000
Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:
> This patch implements new API of the tracevent library:
> int tep_get_ref(struct tep_handle *pevent);
> The API returns the reference counter "ref_count" of the tep handler.
> As "struct tep_handle" is internal only, its members cannot be accessed
> by the library users, the API is used to get the reference counter.
>
> Signed-off-by: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
> ---
> tools/lib/traceevent/event-parse.c | 7 +++++++
> tools/lib/traceevent/event-parse.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index f327c990dedc..c0dd72141a44 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -6774,6 +6774,13 @@ void tep_ref(struct tep_handle *pevent)
> pevent->ref_count++;
> }
>
> +int tep_get_ref(struct tep_handle *pevent)
New functions should use "tep" instead of "pevent". We need to start
removing that name.
I'll just change this patch directly so that you don't need to send a
v4. But for future patches, lets avoid pevent. And when we start
touching functions that use it, we should rename it.
-- Steve
> +{
> + if (pevent)
> + return pevent->ref_count;
> + return 0;
> +}
> +
> void tep_free_format_field(struct tep_format_field *field)
> {
> free(field->type);
> diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
> index cacd0b9f4807..9af316862ed4 100644
> --- a/tools/lib/traceevent/event-parse.h
> +++ b/tools/lib/traceevent/event-parse.h
> @@ -583,6 +583,7 @@ struct tep_handle *tep_alloc(void);
> void tep_free(struct tep_handle *pevent);
> void tep_ref(struct tep_handle *pevent);
> void tep_unref(struct tep_handle *pevent);
> +int tep_get_ref(struct tep_handle *pevent);
>
> /* access to the internal parser */
> void tep_buffer_init(const char *buf, unsigned long long size);
|