On Wed, 28 Nov 2018 09:07:30 +0000
Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:
> +PKG_CONFIG_FILE = libtraceevent.pc
> +define do_install_pkgconfig_file
> + if [ -n "${pkgconfig_dir}" ]; then \
> + cp -f ${PKG_CONFIG_FILE}.template ${PKG_CONFIG_FILE}; \
> + sed -i "s|INSTALL_PREFIX|${1}|g" ${PKG_CONFIG_FILE}; \
> + sed -i "s|LIB_VERSION|${EVENT_PARSE_VERSION}|g" ${PKG_CONFIG_FILE}; \
> + $(call do_install,$(PKG_CONFIG_FILE),$(pkgconfig_dir),644); \
> + else \
> + (echo Failed to locate pkg-config directory) 1>&2; \
> + fi
Might want to run checkpatch.pl before sending, as it can catch
whitespace issues. The above "fi" has a tab after it.
$ ./scripts/checkpatch.pl mbox.patch
ERROR: trailing whitespace
#139: FILE: tools/lib/traceevent/Makefile:285:
+^Ifi^I$
> +endef
|