On Wed, 28 Nov 2018 15:16:27 +0000
Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote:
> +void KsMainWindow::_hideCPUs()
> +{
> + kshark_context *kshark_ctx(nullptr);
> + KsCheckBoxWidget *cpu_cbd;
> + KsCheckBoxDialog *dialog;
> +
> + if (!kshark_instance(&kshark_ctx))
> + return;
> +
> + cpu_cbd = new KsCPUCheckBoxWidget(_data.tep(), this);
> + dialog = new KsCheckBoxDialog(cpu_cbd, this);
> +
> + if (!kshark_ctx->hide_cpu_filter ||
> + !kshark_ctx->hide_cpu_filter->count) {
> + cpu_cbd->setDefault(false);
> + } else {
> + int nCPUs = tep_get_cpus(_data.tep());
> + QVector<bool> v(nCPUs, false);
> +
> + for (int i = 0; i < nCPUs; ++i) {
> + if (tracecmd_filter_id_find(kshark_ctx->hide_cpu_filter,
> + i))
Just a nit, but really that "i))" could have been on the previous line.
No need to send another patch, but let's not get too crazy at breaking
up lines like this ;-)
-- Steve
> + v[i] = true;
> + }
>
|