On Wed, 3 Oct 2018 14:54:58 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Wed, 3 Oct 2018 14:15:52 -0400 > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > Hi Yordan, > > > > I'm using your latest KS for doing some real work (sched_deadline patch > > review so it's perfect). Two nits: > > > > In the event description window, instead of "Cpu" it should be "CPU" as > > it is a proper acronym. > > > > Second, can you do the same thing in the task plot view that you did in > > the CPU view. That is, when the mouse is not over an event, the > > description should show what CPU the task is on, like you did for the > > CPU plot, where it showed what task the mouse is over. > > > Another issue I see. The colors of the CPUs for task plots need to stay > consistent. That is, CPU-1 should be the same color on all task plots. > This is required to see why a task was preempted. Ah, I see what is done. You have the color of the task in the task plot. The colors in the task plots need to be of the CPUs they represent, not the color of the task. We need to see how a task is migrating. Another enhancement (not required for 1.0 as the above requests are), is to have the designated color of the tasks be the background of the text of the tasks name in the left. And we can do the same for the CPUs. -- Steve
|