On Wed, May 23, 2012 at 06:18:18PM +0200, Peter Zijlstra wrote: > On Wed, 2012-05-23 at 09:08 -0700, tip-bot for Borislav Petkov wrote: > > + if (val & BIT_64(62)) { > > + val &= ~BIT_64(62); > > + wrmsrl(msrs[i], val); > > } > > Wouldn't it be much better to name those things, BIT(62), BIT(18) etc. > aren't very descriptive at all. > > MCE_MISC_COUNTER_PRESENT is much more descriptive than BIT(62). I know but I have the exact bit name from the BKDG in the comment above - CntP - and this is used only at one place - here - so no need for the defines, IMHO. But yeah, I see your point too. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html