On Wed, 2012-05-23 at 09:08 -0700, tip-bot for Borislav Petkov wrote: > + if (val & BIT_64(62)) { > + val &= ~BIT_64(62); > + wrmsrl(msrs[i], val); > } Wouldn't it be much better to name those things, BIT(62), BIT(18) etc. aren't very descriptive at all. MCE_MISC_COUNTER_PRESENT is much more descriptive than BIT(62). -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html