On Fri, Dec 13, 2024 at 09:44:23AM +0000, Jon Hunter wrote:
>
> On 13/12/2024 00:03, Ivy Huang wrote:
> > From: Sumit Gupta <sumitg@xxxxxxxxxx>
> >
> > Fix typo in the compatible string of Tegra234 dce-fabric.
> >
> > Signed-off-by: Sumit Gupta <sumitg@xxxxxxxxxx>
> > Signed-off-by: Ivy Huang <yijuh@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > index 984c85eab41a..d08faf6bb505 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > @@ -3995,7 +3995,7 @@
> > };
> > dce-fabric@de00000 {
> > - compatible = "nvidia,tegra234-sce-fabric";
> > + compatible = "nvidia,tegra234-dce-fabric";
> > reg = <0x0 0xde00000 0x0 0x40000>;
> > interrupts = <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH>;
> > status = "okay";
>
>
> LGTM! However, we are missing a 'Fixes' tag. We should add the following
> above the 'signed-off-by'.
>
> Fixes: 302e154000ec ("arm64: tegra: Add node for CBB 2.0 on Tegra234")
>
> Thierry, do you want to apply the fixes tag when merging? Could also be a
> candidate for stable.
Yeah, I can add the fixes tag, no need to resend. That should also take
care of it getting picked up into stable automatically.
Thierry
> Otherwise ...
>
> Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>
> Jon
>
> --
> nvpublic
>
Attachment:
signature.asc
Description: PGP signature
