On Fri, Dec 13, 2024 at 09:51:30AM +0000, Jon Hunter wrote:
>
> On 12/12/2024 21:11, Brad Griffis wrote:
> > For interrupt-map entries, the DTS specification requires
> > that #address-cells is defined for both the child node and the
> > interrupt parent. For the PCIe interrupt-map entries, the parent
> > node ("gic") has not specified #address-cells. The existing layout
> > of the PCIe interrupt-map entries indicates that it assumes
> > that #address-cells is zero for this node.
> >
> > Explicitly set #address-cells to zero for "gic" so that it complies
> > with the device tree specification.
> >
> > Signed-off-by: Brad Griffis <bgriffis@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > index 984c85eab41a..e1c07c99e9bd 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > @@ -4010,6 +4010,7 @@ ccplex@e000000 {
> > gic: interrupt-controller@f400000 {
> > compatible = "arm,gic-v3";
> > + #address-cells = <0>;
> > reg = <0x0 0x0f400000 0x0 0x010000>, /* GICD */
> > <0x0 0x0f440000 0x0 0x200000>; /* GICR */
> > interrupt-parent = <&gic>;
>
>
> Can you add the fixes tag for this?
>
> BTW, I had a quick look and this appears to be a common problem across all
> Tegra devices, Tegra210, Tegra186 and Tegra194. Should we fix up all while
> we are at it?
Yeah, I think we should fix these up going as far back as Tegra20. I
don't think we've ever seen any fallout from this being broken and I
don't exactly understand why. I'll dig through some code and run some
tests to see if I can get to the bottom of this.
I can take care of fixing up the older boards.
Thierry
Attachment:
signature.asc
Description: PGP signature
