On 13/12/2024 11:22, Thierry Reding wrote:
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> index 984c85eab41a..d08faf6bb505 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> @@ -3995,7 +3995,7 @@
>>> };
>>> dce-fabric@de00000 {
>>> - compatible = "nvidia,tegra234-sce-fabric";
>>> + compatible = "nvidia,tegra234-dce-fabric";
>>> reg = <0x0 0xde00000 0x0 0x40000>;
>>> interrupts = <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH>;
>>> status = "okay";
>>
>>
>> LGTM! However, we are missing a 'Fixes' tag. We should add the following
>> above the 'signed-off-by'.
>>
>> Fixes: 302e154000ec ("arm64: tegra: Add node for CBB 2.0 on Tegra234")
>>
>> Thierry, do you want to apply the fixes tag when merging? Could also be a
>> candidate for stable.
>
> Yeah, I can add the fixes tag, no need to resend. That should also take
> care of it getting picked up into stable automatically.
No, this changed some days ago. If this is a real fix which should go to
stable, then with proper explanation what is the bug and how it affects
users, you need cc-stable tag.
Best regards,
Krzysztof
