13.12.2021 19:06, Thierry Reding пишет: > On Fri, Dec 10, 2021 at 06:28:36PM +0300, Dmitry Osipenko wrote: >> 10.12.2021 16:43, Thierry Reding пишет: >>> On Thu, Dec 09, 2021 at 11:34:39PM +0300, Dmitry Osipenko wrote: >>>> 09.12.2021 20:33, Thierry Reding пишет: >>>>> From: Thierry Reding <treding@xxxxxxxxxx> >>>>> >>>>> The Tegra memory controller provides reset controls for hotflush reset, >>>>> so the #reset-cells property must be specified. >>>>> >>>>> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> >>>>> --- >>>>> arch/arm/boot/dts/tegra114.dtsi | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi >>>>> index 328425dba023..ce7410ee08b8 100644 >>>>> --- a/arch/arm/boot/dts/tegra114.dtsi >>>>> +++ b/arch/arm/boot/dts/tegra114.dtsi >>>>> @@ -542,6 +542,7 @@ mc: memory-controller@70019000 { >>>>> >>>>> interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>; >>>>> >>>>> + #reset-cells = <1>; >>>>> #iommu-cells = <1>; >>>>> }; >>>>> >>>>> >>>> >>>> This will conflict with the patch that adds video decoder node [1]. >>>> Since the VDE patch was sent out earlier, I suggest you to drop this patch. >>>> >>>> [1] >>>> https://patchwork.ozlabs.org/project/linux-tegra/patch/20211208173609.4064-23-digetx@xxxxxxxxx/ >>> >>> I prefer to keep this separate because it actually gives the reason for >>> why this is added, whereas with the VDE node patch it looks like it's >>> there by mistake. >> >> So the direct reference to the MC using TEGRA114_MC_RESET_VDE is a >> mistake to you. I disagree. > > That's not what I'm saying. I'm saying that it's not obvious from the > patch description or from the rest of the content why that #reset-cells > is added. It looks out of place. > >> I don't mind if you'll keep this patch, but then please don't forget to >> resolve the conflict, or we may have two #reset-cells entries. > > Yeah, no worries, I'll take care of that. Again, I already took care about it [1]. Please just rebase your patches ;) [1] https://patchwork.ozlabs.org/project/linux-tegra/patch/20211211211412.10791-26-digetx@xxxxxxxxx/