01.06.2021 20:59, Thierry Reding пишет: > From: Thierry Reding <treding@xxxxxxxxxx> > > Hi, > > this set of patches converges the feature sets of the pre-Tegra186 and > the post-Tegra186 memory controller drivers such that newer chips can > take advantage of some features that were previously only implemented > on earlier chips. > > Note that this looks a bit daunting from a diffstat point of view but > the bulk of this is in the first two patches that basically shuffle > around where some of the per-memory-client register definitions are > located, hence the big number of changed lines. > > Changes in v2: > - split patches up a bit for smaller, logical changes > - add better documentation for ->probe() callback > - use SET_SYSTEM_SLEEP_OPS where appropriate > - include Tegra194 separation patch > - use prefix for global variables > - drop commented-out code Everything looks and works good, thank you. I made a minor comment about the function which can be made static, perhaps you could improve it locally if you will take these patches via Tegra tree.