On Wed, Jun 02, 2021 at 09:53:03AM +0200, Krzysztof Kozlowski wrote: > On 01/06/2021 19:59, Thierry Reding wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > Keep the directory structure consistent by splitting the Tegra194 data > > into a separate file. > > > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > --- > > drivers/memory/tegra/Makefile | 2 +- > > drivers/memory/tegra/mc.h | 5 + > > drivers/memory/tegra/tegra186.c | 1349 +----------------------------- > > drivers/memory/tegra/tegra194.c | 1353 +++++++++++++++++++++++++++++++ > > 4 files changed, 1360 insertions(+), 1349 deletions(-) > > create mode 100644 drivers/memory/tegra/tegra194.c > > > > diff --git a/drivers/memory/tegra/Makefile b/drivers/memory/tegra/Makefile > > index 1af0fefacdda..c992e87782d2 100644 > > --- a/drivers/memory/tegra/Makefile > > +++ b/drivers/memory/tegra/Makefile > > @@ -8,7 +8,7 @@ tegra-mc-$(CONFIG_ARCH_TEGRA_124_SOC) += tegra124.o > > tegra-mc-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra124.o > > tegra-mc-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210.o > > tegra-mc-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186.o > > -tegra-mc-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra186.o > > +tegra-mc-$(CONFIG_ARCH_TEGRA_194_SOC) += tegra186.o tegra194.o > > > > obj-$(CONFIG_TEGRA_MC) += tegra-mc.o > > (...) > > > diff --git a/drivers/memory/tegra/tegra194.c b/drivers/memory/tegra/tegra194.c > > new file mode 100644 > > index 000000000000..3ae6fbb76997 > > --- /dev/null > > +++ b/drivers/memory/tegra/tegra194.c > > @@ -0,0 +1,1353 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Copyright (C) 2017-2021 NVIDIA CORPORATION. All rights reserved. > > + */ > > + > > +#include <soc/tegra/mc.h> > > + > > +#include <dt-bindings/memory/tegra194-mc.h> > > + > > +#include "mc.h" > > + > > +#if defined(CONFIG_ARCH_TEGRA_194_SOC) > > Do you actually need this #ifdef? This CONFIG_ARCH... symbol is already > used in Makefile, so the unit should not be built on anything else. This is indeed redundant now. Good catch! Thierry
Attachment:
signature.asc
Description: PGP signature
