Re: [PATCH v2 07/12] memory: tegra: Parameterize interrupt handler

[Dmitry Osipenko <digetx@xxxxxxxxx>]

01.06.2021 21:53, Dmitry Osipenko пишет:
> 01.06.2021 20:59, Thierry Reding пишет:
>> --- a/drivers/memory/tegra/mc.h
>> +++ b/drivers/memory/tegra/mc.h
>> @@ -135,9 +135,13 @@ extern const struct tegra_mc_soc tegra210_mc_soc;
>>      defined(CONFIG_ARCH_TEGRA_132_SOC) || \
>>      defined(CONFIG_ARCH_TEGRA_210_SOC)
>>  int tegra30_mc_probe(struct tegra_mc *mc);
>> +irqreturn_t tegra30_mc_handle_irq(int irq, void *data);
> 
> tegra30_mc_handle_irq() doesn't need to be made global, it's defined and
> used only within mc.h.
> 

You could make this function static and annotate it with maybe_unused.