Re: [PATCH v1 4/9] ARM: tegra: Enable UDC on TrimSlice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2017 07:24 PM, Peter Chen wrote:
On Wed, Jul 05, 2017 at 08:19:53PM +0300, Dmitry Osipenko wrote:
From: Thierry Reding <treding@xxxxxxxxxx>

Override the compatible string of the first USB controller to enable
device mode.

Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
---
  arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/tegra20-trimslice.dts b/arch/arm/boot/dts/tegra20-trimslice.dts
index b902ab594afa..96b4f3f9827b 100644
--- a/arch/arm/boot/dts/tegra20-trimslice.dts
+++ b/arch/arm/boot/dts/tegra20-trimslice.dts
@@ -336,7 +336,9 @@
  	};
usb@c5000000 {
+		compatible = "nvidia,tegra20-udc";
  		status = "okay";
+		dr_mode = "otg";

If this board supports peripheral-only, you need to
set dr_mode as "peripheral".

I agree here. Even if the ports can theoretically do otg, and DT is supposed to represent HW not SW, given we have no SW support for actual OTG, it'd be best not to change the DT to OTG until it's actually useful to do so. This comment applies to the patches I ack'd already too.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux