Re: [PATCH v1 4/9] ARM: tegra: Enable UDC on TrimSlice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06.07.2017 15:51, Marcel Ziswiler wrote:
> On Thu, 2017-07-06 at 13:24 +0300, Dmitry Osipenko wrote:
>> On 06.07.2017 04:24, Peter Chen wrote:
>>> On Wed, Jul 05, 2017 at 08:19:53PM +0300, Dmitry Osipenko wrote:
>>>> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane
>>>> .org>
>>>>
>>>> Override the compatible string of the first USB controller to
>>>> enable
>>>> device mode.
>>>>
>>>> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@pub
>>>> lic.gmane.org>
>>>> ---
>>>>  arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/tegra20-trimslice.dts
>>>> b/arch/arm/boot/dts/tegra20-trimslice.dts
>>>> index b902ab594afa..96b4f3f9827b 100644
>>>> --- a/arch/arm/boot/dts/tegra20-trimslice.dts
>>>> +++ b/arch/arm/boot/dts/tegra20-trimslice.dts
>>>> @@ -336,7 +336,9 @@
>>>>  	};
>>>>  
>>>>  	usb@c5000000 {
>>>> +		compatible = "nvidia,tegra20-udc";
>>>>  		status = "okay";
>>>> +		dr_mode = "otg";
>>>
>>> If this board supports peripheral-only, you need to
>>> set dr_mode as "peripheral".
>>>
>>
>> It should support OTG, but we aren't going to implement the host mode
>> switch for
>> now. Stephen claims that the host mode is working with the tegra-ehci 
>> driver, it
>> would be nice if anyone could confirm this.
> 
> I can confirm that on Colibri T20, Apalis/Colibri T30 and Apalis TK1
> host mode works just fine with the regular tegra-ehci driver.
> 

Good to know, thank you :)

> I'm about to give your patch set a try on those boards as well and will
> give further feedback.
> 

Okay, but we won't be able to switch those boards to the UDC driver until the
peripheral/host mode switching would be implemented. As Stephen pointed, it
would be a user-visible regression.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux