On 08/02/2013 12:09 AM, Stephen Warren wrote: > On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: >> Some of the PHY parameters are not set according to the TRMs: >> >> - UTMIP_FS_PREABMLE_J should be set, not cleared >> - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set >> - UTMIP_PD_CHRG should be set in host mode and cleared in device mode >> - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not set > >> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c > >> #define UTMIP_XCVR_SETUP(x) (((x) & 0xf) << 0) >> +#define UTMIP_XCVR_SETUP_MSB(x) ((((x) & 0x7f) >> 4) << 22) > > You may as well s/0x7f/0x70/ since the shift clears the 4 LSBs. I'm > pretty sure I mentioned this in downstream review. Perhaps check my > review comments to see if anything else was missed? > Well in my opinion that increases the risk of typoing the mask. I'll fix along with the other things. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
