On 08/01/2013 11:05 AM, Matthieu CASTET wrote: > Hi, > > Le Wed, 31 Jul 2013 18:41:57 +0100, > Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx> a écrit : > >> The has_hostpc capability bit indicates that the host controller has >> the HOSTPC register extensions, but at the same time enables clock >> disabling power saving features with the PHY Low Power Clock Disable >> (PHCD) bit. >> >> However, some host controllers have the HOSTPC extensions but don't >> support the low-power feature, so the PHCD bit must not be set on >> those controllers. Add a separate capability bit for the low-power >> feature instead, and change all existing users of has_hostpc to use >> this new capability bit. >> >> The idea for this commit is taken from an old 2012 commit that never >> got merged ("disociate chipidea PHY low power suspend control from >> hostpc") > Note that because of the different register layout (see "add phy low > power suspend for older chipidea core" commit in the same series), we > should not set has_tdi_phy_lpm if has_hostpc == 0 with the current code. > > May be you should have change the ehci->has_hostpc to (ehci->has_hostpc > && ehci->has_tdi_phy_lpm). Hmm, I see. Do you think there could be a case where that could get accidentally get triggered via autodetection? That patch series seems to set either both or neither. And I figure no one will be explicitly setting that flag (if has_hostpc == 0) without implementing the non-has_hostpc case first. > > BTW Alan make some comment on the commit : > http://marc.info/?l=linux-usb&m=133701342028213&w=2 > > They may apply to your commit. > >> >> Inspired-by: Matthieu CASTET <matthieu.castet@xxxxxxxxxx> >> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx> >> --- >> drivers/usb/chipidea/host.c | 1 + >> drivers/usb/host/ehci-hub.c | 14 +++++++------- >> drivers/usb/host/ehci.h | 1 + >> 3 files changed, 9 insertions(+), 7 deletions(-) >> -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html