* Thierry Reding wrote: > * Stephen Warren wrote: > > On 06/11/2012 09:05 AM, Thierry Reding wrote: [...] > > > +static int tegra_pcie_disable_msi(struct platform_device *pdev) > > > > Should this free pcie->msi->pages? > > Yes it should. I actually mention making that change in the changelog but > in fact didn't. This is really moot because the driver cannot be built as a module currently because arch_setup_msi_irq() and arch_teardown_msi_irq() need to be built-in so tegra_pcie_disable_msi() will be called only just before the machine is shut down. Perhaps this is something that should be addressed? Or is it just not worth the effort? Thierry
Attachment:
pgpKmQaMWfGAj.pgp
Description: PGP signature
