On 06/12/2012 12:10 AM, Thierry Reding wrote: > * Thierry Reding wrote: >> * Stephen Warren wrote: >>> On 06/11/2012 09:05 AM, Thierry Reding wrote: > [...] >>>> +static int tegra_pcie_disable_msi(struct platform_device >>>> *pdev) >>> >>> Should this free pcie->msi->pages? >> >> Yes it should. I actually mention making that change in the >> changelog but in fact didn't. > > This is really moot because the driver cannot be built as a module > currently because arch_setup_msi_irq() and arch_teardown_msi_irq() > need to be built-in so tegra_pcie_disable_msi() will be called only > just before the machine is shut down. > > Perhaps this is something that should be addressed? Or is it just > not worth the effort? Well, if the driver provides a shutdown/removal path at all, it seems like it should be complete. I assume it's trivial to free those pages? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
