Re: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Stephen Warren wrote:
> On 06/11/2012 09:05 AM, Thierry Reding wrote:
> > Device tree support for the TPS6586x PMU used on Harmony has recently
> > been added. This commit adds the required device tree nodes to probe the
> > PMU from the device tree.
> 
> > diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts
> 
> > +		tps6586x@34 {
> > +			compatible = "ti,tps6586x";
> > +			reg = <0x34>;
> > +			interrupts = <0 88 0x4>;
> > +
> > +			#gpio-cells = <2>;
> > +			gpio-controller;
> > +
> > +			regulators {
> 
> Per the TPS65911 discussion on regulator bindings, this node should have:
> 
> 	#address-cells = <1>;
> 	#size-cells = <0>;
> 
> > +				sm0 {
> 
> Each of these nodes should be named regulator@0, regulator@1, etc.
> 
> Within each of these nodes, you need a matching reg property.
> 
> 	reg = <0>;
> 
> and something to identify which regulator within the chip this node
> configurations, although I don't think we've reached a final decision on
> the property name.
> 
> See the the following for details:
> 
> http://www.spinics.net/lists/linux-tegra/msg05577.html

Okay, I'll monitor that discussion and see what you end up with. I guess I'll
have to update the tps6586x binding when that decision has been reached and
add a patch to this series.

Thierry

Attachment: pgpbRbCrtHVRZ.pgp
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux